[LLVM] Update handling of default runtime targets #136591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuber6
requested review from
Meinersbur,
jdoerfert,
michaelrj-google,
petrhosek,
shiltian and
ye-luo
Summary: This patch changes the handling for `default` in the LLVM runtimes list. Currently it's some different path, but I think it's more straightforward if we have everything go through the same handling and just semantically replace `default` with the target LLVM is building for (current behavior). The one thing that this changes I'm aware of is that instead of something like `ninja check-libc` we now have `ninja check-libc-x86_64-unknown-linux-gnu`. This will almost surely break some bots with hard-coded check projects, so I'm thinking the easiest solution is to *always* define the `check-<runtime>` and every time we add a specific target, it adds itself as a dependency to the global `check-<runtime>`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch changes the handling for
defaultin the LLVM runtimes list.Currently it's some different path, but I think it's more
straightforward if we have everything go through the same handling and
just semantically replace
defaultwith the target LLVM is building for(current behavior).
The one thing that this changes I'm aware of is that instead of
something like
ninja check-libcwe now haveninja check-libc-x86_64-unknown-linux-gnu. This will almost surely break somebots with hard-coded check projects, so I'm thinking the easiest
solution is to always define the
check-<runtime>and every time weadd a specific target, it adds itself as a dependency to the global
check-<runtime>.